Repoint test-fixtures submodule and add EPYC integration test scaffolding#86
Open
vringar wants to merge 1 commit intoPSPReverse:masterfrom
Open
Repoint test-fixtures submodule and add EPYC integration test scaffolding#86vringar wants to merge 1 commit intoPSPReverse:masterfrom
vringar wants to merge 1 commit intoPSPReverse:masterfrom
Conversation
2 tasks
Metrics
|
| Metric | Value |
|---|---|
| Files Processed | 68 |
| Stdout Lines | 14,965 |
| Stderr Lines | 156 |
| Total Lines | 15,121 |
| Error Ratio | 1.03% |
PSPTool python library metrics
| Status | Count | Percentage |
|---|---|---|
| ✓ Successful | 68 | 100.0% |
| ✗ Failed | 0 | 0.0% |
| Total | 68 | 100% |
All files parsed successfully!
The previous submodule URL git@github.com:cwerling/PSPTool-fixtures.git returns 'Repository not found' (likely casualty of the LFS-quota recreations the commit log mentions). PSPReverse/Test-PSPTool is the active firmware corpus for the org (54+ ROMs spanning AM4 / X399 / X470 / Threadripper / Naples) and the natural home for the new EPYC fixtures. Submodule path stays at tests/integration/fixtures; layout changes from fixtures/roms/ to fixtures/test_files/ to match the corpus repo's flat layout. The TestZenGenerationBackfill class' filename keys are updated to the new Vendor_Model_BIOS.ext naming convention. Pinned at Test-PSPTool master HEAD bca9c0e for now; bump once the companion PR (Add EPYC test ROMs + split test_psptool.py) lands. Until then TestZenGenerationBackfill skips with the documented no-fixtures-present message; integration smoke tests run as before against the existing 54-file corpus.
d6e5506 to
53d7fb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two pieces of infrastructure cleanup that were originally bundled with #85 but are independently useful:
tests/integration/fixturescurrently points atgit@github.com:cwerling/PSPTool-fixtures.git, which returns "Repository not found" — almost certainly collateral from the LFS-quota recreations the commit log mentions. Anyone runninggit submodule update --initon a fresh checkout today fails immediately. Switching togit@github.com:PSPReverse/Test-PSPTool.git, which is the org's active firmware corpus (54 ROMs, AM4 / X399 / Naples era), restores submodule init.fixtures/roms/tofixtures/test_files/to match the Test-PSPTool repo's flat layout, andTestZenGenerationBackfillis added totests/integration/test_rom_files.py. It maps the 5 EPYC fixture filenames to expected Zen generations and asserts via_find_fixture+subTest. The class skips cleanly today (No EPYC fixtures present under tests/integration/fixtures/test_files) — it starts asserting only after Test-PSPTool gains the EPYC ROMs and the gitlink in this PR is bumped to a SHA that contains them.Why this is its own PR
This work is a strict superset of "the submodule URL is dead." The integration-test class is dormant scaffolding until Test-PSPTool catches up, and bundling it with the back-fill in #85 muddies the review (one PR mixing fix-the-bug with fix-the-CI-corpus-pointer). Keeping them separate means:
PSPReverse/Test-PSPToolis the right destination, and whether the dormant test class shape is acceptable.What's in the PR
Single commit:
.gitmodules— URL change togit@github.com:PSPReverse/Test-PSPTool.gittests/integration/fixtures— gitlink moved to currentTest-PSPToolmaster HEADbca9c0e. Real commit, exists, has the existing 54-ROM corpus.tests/integration/test_rom_files.py—rom_fixtures_pathupdated tofixtures/test_files; newTestZenGenerationBackfillclass.Test plan
TestRomFiles.*): runs against the new submodule pointer (Test-PSPTool master, 54 ROMs, AM4 / X399 / Naples era) — all pass, AM4 combo controlX470D4U2-2T 3.40keeps existing combo_dir output unchanged.TestZenGenerationBackfill: skips with the documented "No EPYC fixtures present" message, exactly as expected on this gitlink.Follow-up
A companion change in
PSPReverse/Test-PSPTooladds 5 EPYC fixture files (Rome / Milan / Genoa / Siena / Turin) undertest_files/and refreshestest_psptool.pyfor the current PSPTool API (it importsHeaderEntryand walkspsp.blob.fets, both gone). Once that lands, a one-line gitlink bump in this repo flipsTestZenGenerationBackfillfrom skip to assert.